Re: [PATCH 22/25] progress.c: add a stop_progress_early() function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 22/25] progress.c: add a stop_progress_early() function
From: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
Date: Thu, 24 Jun 2021 12:35:32 +0200
Cc: Junio C Hamano <gitster@xxxxxxxxx>, SZEDER Gábor <szeder.dev@xxxxxxxxx>, René Scharfe <l.s.r@xxxxxx>, Taylor Blau <me@xxxxxxxxxxxx>, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
In-reply-to: <patch-22.25-e7f8314867d-20210623T155626Z-avarab@gmail.com>
References: <YNKWsTsQgB2Ijxu7@nand.local> <cover-00.25-00000000000-20210623T155626Z-avarab@gmail.com> <patch-22.25-e7f8314867d-20210623T155626Z-avarab@gmail.com>
User-agent: Debian GNU/Linux 11 (bullseye); Emacs 27.1; mu4e 1.5.12

On Wed, Jun 23 2021, Ævar Arnfjörð Bjarmason wrote:

> +	strbuf_addf(&sb, _(", done at %"PRIuMAX" items, expected %"PRIuMAX"."),
> +		    progress->total, progress->last_update);

These two need a (uintmax_t) cast like the rest of such sprintfs in the
file, as I discovered with the OSX CI.

References:
- Re: [PATCH 0/7] progress: verify progress counters in the test suite
  - From: Taylor Blau
- [PATCH 00/25] progress.c: various fixes + SZEDER's RFC code
  - From: Ævar Arnfjörð Bjarmason
- [PATCH 22/25] progress.c: add a stop_progress_early() function
  - From: Ævar Arnfjörð Bjarmason

Prev by Date: [PATCH] test-lib.sh: set COLUMNS=80 for --verbose repeatability
Next by Date: Re: [PATCH 0/8] test-lib tests: split off subtest code in t0000 into lib-subtest.sh
Previous by thread: [PATCH 22/25] progress.c: add a stop_progress_early() function
Next by thread: Re: [PATCH 22/25] progress.c: add a stop_progress_early() function
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]