On Mon, Sep 03, 2007 at 02:19:05AM CEST, Jakub Narebski wrote:
> [Cc: Martin Koegler <mkoegler@xxxxxxxxxxxxxxxxx>,
> Petr Baudis <pasky@xxxxxxx>, git@xxxxxxxxxxxxxxx]
>
> Martin Koegler wrote:
>
> > Patch 4 now only generates the links, if they are enabled.
> > The header contains a new link to show/hide the links.
> > The state is remembered via a cookie across pages.
>
> I'd rather have patch adding cookie management (are they only JavaScript,
> or also server side?) as a separate patch.
This is purely in-Javascript thing, so I don't think a separate patch
makes much sense.
To hijack this post a bit, another patch in the queue (the incremental
blame thingie) introduces blame.js. Do you think that we should keep the
.js files separate, or instead have one big gitweb.js with everything?
I'm inclined to the second possibility in order to reduce the number of
requests, but it comes at a price of slightly worse maintainability.
--
Petr "Pasky" Baudis
Early to rise and early to bed makes a male healthy and wealthy and dead.
-- James Thurber
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
