On Fri, Jun 4, 2021 at 2:03 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
>
> On Fri, Jun 4, 2021 at 1:44 PM Matthew Rogers via GitGitGadget
> <gitgitgadget@xxxxxxxxx> wrote:
> > When building on windows users have the option to use vcpkg to provide
> > the dependencies needed to compile. Previously, this was used only when
> > using the Visual Studio generator which was not ideal because:
> >
> > - Not all users who want to use vcpkg use the Visual Studio
> > generators.
> >
> > - Some versions of Visual Studio 2019 moved away from using the
> > VS 2019 by default, making it impossible for Visual Studio to
> > configure the project in the likely event that it couldn't find the
> > dependencies.
>
> Is there something missing between "using the" and "VS 2019"? I'm
> having a hard time trying to understand what this bullet point is
> saying due to this apparent gap.
>
Yeah, this should really read
- Some versions of Visual Studio 2019 moved away from using the
VS 2019 _Generator_ by default, making it impossible for Visual Studio to
configure the project in the likely event that it couldn't find the
dependencies.
> > - Inexperienced users of CMake are very likely to get tripped up by
> > the errors caused by a lack of vcpkg, making the above bullet point
> > both annoying and hard to debug.
> >
> > As such, lets make using vcpkg the default on windows. Users who want
> > to avoid using vcpkg can disable it by passing -DNO_VCPKG=TRUE.
>
> s/lets/let's/
>
> > Signed-off-by: Matthew Rogers <mattr94@xxxxxxxxx>
--
Matthew Rogers
