On Fri, Jun 4, 2021 at 1:44 PM Matthew Rogers via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > It does not make sense to attempt to set MSGFMT_EXE when NO_GETTEXT is > configured, as such add a check for NO_GETTEXT before attempting to set > it. This would be easier to digest if "as such" is the start of a new sentence: "As such...". Or "Therefore, add a check...". > suggested-by: Johannes Schindelin <johannes.schindelin@xxxxxx> > Signed-off-by: Matthew Rogers <mattr94@xxxxxxxxx> s/suggested-by/Suggested-by:/ Tiny little nits, both. Don't know if it's worth a re-roll, but if you happen to re-roll for some other reason, perhaps these could be tweaked.
