On Thu, May 20, 2021 at 5:51 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > -test_expect_success 'refs/worktree must not be packed' ' > > +# The 'packed-refs' files is stored directly in .git/. This means it is global > > +# to the repository, and can only contain refs that are shared across all > > +# worktrees. > > +test_expect_success REFFILES 'refs/worktree must not be packed' ' > > git pack-refs --all && > > test_path_is_missing .git/refs/tags/wt1 && > > test_path_is_file .git/refs/worktree/foo && > > Nit but also chicken & egg: Let's keep the "pack-refs --all" though > under reftable in its own test, and do the test_path_* assertions just > under REFFILES, i.e. does/should pack-refs warn/error under reftable as > redundant, succeed silently? I don't understand your comment. This test is checking constraints on worktrees that are only relevant for loose/packed storage. In fact, under reftable, there is no such thing as a "packed ref" storage class. This test is just not relevant for reftable, and I tried explaining in the comment why this is so. Happy to hear how to further clarify this comment. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
