On Tue, Apr 27 2021, Han-Wen Nienhuys via GitGitGadget wrote: > From: Han-Wen Nienhuys <hanwen@xxxxxxxxxx> > > Packing refs (and therefore checking that certain refs are not packed) is a > property of the packed/loose ref storage. Add a comment to explain what the test > checks. > > Signed-off-by: Han-Wen Nienhuys <hanwen@xxxxxxxxxx> > --- > t/t1415-worktree-refs.sh | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/t/t1415-worktree-refs.sh b/t/t1415-worktree-refs.sh > index 7ab91241ab7c..d6e6e523bbba 100755 > --- a/t/t1415-worktree-refs.sh > +++ b/t/t1415-worktree-refs.sh > @@ -16,7 +16,10 @@ test_expect_success 'setup' ' > git -C wt2 update-ref refs/worktree/foo HEAD > ' > > -test_expect_success 'refs/worktree must not be packed' ' > +# The 'packed-refs' files is stored directly in .git/. This means it is global > +# to the repository, and can only contain refs that are shared across all > +# worktrees. > +test_expect_success REFFILES 'refs/worktree must not be packed' ' > git pack-refs --all && > test_path_is_missing .git/refs/tags/wt1 && > test_path_is_file .git/refs/worktree/foo && Nit but also chicken & egg: Let's keep the "pack-refs --all" though under reftable in its own test, and do the test_path_* assertions just under REFFILES, i.e. does/should pack-refs warn/error under reftable as redundant, succeed silently?
