Jeff King wrote: > On Thu, May 20, 2021 at 10:18:57AM +0200, Ævar Arnfjörð Bjarmason wrote: > > > A re-roll of [1], the work I based v1 on top of has landed in master, > > so this has been rebased on master. > > > > The changes here are minor, just a typo fix / commit message > > clarification, moving "require" closer to where it's used, and finally > > a new 10/10 patch to s/cwd/getcwd/g. > > I like all of this, except for the change in the interface of > Git::config_regexp(). You mention that it's new-ish, and probably not in > wide use. And I agree that's probably true. But it feels like violating > a principle of not breaking APIs, and we should stick to that principle > and not bend it for "well, it's not that old an API". APIs are broken all the time. That's why they have versions. Anyway, I find it odd that the git project cares about an API promise of an outdated language steadily in decline (it's peak was in 2004 [1]), and yet it does not provide an API of its own, like virtually all important software. Shouldn't we care more about a C API than a Perl API? (a non-existent API is orders of magnitude worse than an API that broke once) [1] https://www.tiobe.com/tiobe-index/perl/ -- Felipe Contreras
