On Thu, May 20, 2021 at 10:18:57AM +0200, Ævar Arnfjörð Bjarmason wrote: > A re-roll of [1], the work I based v1 on top of has landed in master, > so this has been rebased on master. > > The changes here are minor, just a typo fix / commit message > clarification, moving "require" closer to where it's used, and finally > a new 10/10 patch to s/cwd/getcwd/g. I like all of this, except for the change in the interface of Git::config_regexp(). You mention that it's new-ish, and probably not in wide use. And I agree that's probably true. But it feels like violating a principle of not breaking APIs, and we should stick to that principle and not bend it for "well, it's not that old an API". I'd find it more compelling if it the existing interface was broken or hard to avoid changing. But couldn't we just add a new function with the extra info (config_regexp_with_values() or something)? -Peff
