On 5/25/2021 2:32 AM, Junio C Hamano wrote:
> Derrick Stolee <stolee@xxxxxxxxx> writes:
>
>>> So we silently convert -1 to 2^64-1, and call it a day.
>>
>> That works for me. I'll send a v2 with that tomorrow unless someone
>> presents a better option.
>
> I'll queue with this tweak for tonight's integration run.
>
> Thanks.
>
> 1: d327f7d3b9 ! 1: e2b05746e1 t1092: use GIT_PROGRESS_DELAY for consistent results
> @@ Commit message
> values may be different as those indexes have a different number of
> entries.
>
> - Instead, use GIT_PROGRESS_DELAY=100000 to ensure that any reasonable
> - machine running these tests would never display delayed progress
> - indicators.
> + Instead, use GIT_PROGRESS_DELAY=-1 (which will turn into UINT_MAX)
> + to ensure that any reasonable machine running these tests would
> + never display delayed progress indicators.
>
> Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx>
> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
> @@ t/t1092-sparse-checkout-compatibility.sh: init_repos () {
> (
> cd sparse-checkout &&
> - "$@" >../sparse-checkout-out 2>../sparse-checkout-err
> -+ GIT_PROGRESS_DELAY=100000 "$@" >../sparse-checkout-out 2>../sparse-checkout-err
> ++ GIT_PROGRESS_DELAY=-1 "$@" >../sparse-checkout-out 2>../sparse-checkout-err
> ) &&
> (
> cd sparse-index &&
> - "$@" >../sparse-index-out 2>../sparse-index-err
> -+ GIT_PROGRESS_DELAY=100000 "$@" >../sparse-index-out 2>../sparse-index-err
> ++ GIT_PROGRESS_DELAY=-1 "$@" >../sparse-index-out 2>../sparse-index-err
> )
> }
>
> @@ t/t1092-sparse-checkout-compatibility.sh: init_repos () {
> (
> cd full-checkout &&
> - "$@" >../full-checkout-out 2>../full-checkout-err
> -+ GIT_PROGRESS_DELAY=100000 "$@" >../full-checkout-out 2>../full-checkout-err
> ++ GIT_PROGRESS_DELAY=-1 "$@" >../full-checkout-out 2>../full-checkout-err
> ) &&
> run_on_sparse "$@"
> }
Thank you for proactively modifying the patch. This works
for me. I didn't realize that this was affecting other
contributors [1] until I woke up this morning.
[1] https://lore.kernel.org/git/036b01d750ed$642b75c0$2c826140$@nexbridge.com/
Thanks,
-Stolee
