On 20/05/21 11.02, Alex Henrie wrote:
On Wed, May 19, 2021 at 8:22 PM Bagas Sanjaya <bagasdotme@xxxxxxxxx> wrote:
On 18/05/21 13.18, Alex Henrie wrote:
- warning(_("reject %s because shallow roots are not allowed to be updated"),
+ warning(_("rejected %s because shallow roots are not allowed to be updated"),
From descriptive to null-subject past tense, right?
I'm not sure what the best way is to describe the grammar here. I
would say that the "ed" makes it clear that the message is a
description of what did happen rather than an imperative command
concerning what should happen.
-Alex
Looks OK.
So the error had happened, and we needed to express the situation.
Because it happened on the past, using past tense was obviously the
right thing.
Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx>
--
An old man doll... just what I always wanted! - Clara
