Re: [PATCH v3 10/30] subtree: t7900: add a test for the -h flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 30 Apr 2021 06:22:50 -0600,
Bagas Sanjaya wrote:
> 
> On 28/04/21 04.17, Luke Shumaker wrote:
> > It's a dumb test, but it's surprisingly easy to break.
> 
> Why did you say that? Very sensitive?

Because I very nearly sent v1 of this patchset with a broken '-h' flag
:)

I don't recall for certain, but I think the mistake I made was
allowing the ordering of `eval "$(echo "$OPTS_SPEC" | git rev-parse
--parseopt -- "$@")"` and `. git-sh-setup` to get flipped.  That
certainly will break '-h', anyway.

-- 
Happy hacking,
~ Luke Shumaker



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux