On Fri, Apr 23, 2021 at 3:43 PM Luke Shumaker <lukeshu@xxxxxxxxxxx> wrote: > $* is for when you want to smash things together, whitespace-separated; > $@ is for when you want them to be separate strings. There are a couple > of places in subtree that erroneously use $@ when smashing args together > in to an error message. Can we be explicit and say "$@" in the commit message rather than bare $@ since the unquoted form is not magical and acts exactly like $*. Also: s/in to/into/ Nit: I have some trouble following what the commit message is actually trying to say with "smash things" and "separate strings". It might be simpler to say merely that use of "$@" in these particular instances is overkill and possibly misleading to readers not familiar with the finer details of $* vs. "$@". The patch itself makes sense.
