From: Luke Shumaker <lukeshu@xxxxxxxxxxx>
$* is for when you want to smash things together, whitespace-separated;
$@ is for when you want them to be separate strings. There are a couple
of places in subtree that erroneously use $@ when smashing args together
in to an error message.
Signed-off-by: Luke Shumaker <lukeshu@xxxxxxxxxxx>
---
contrib/subtree/git-subtree.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/subtree/git-subtree.sh b/contrib/subtree/git-subtree.sh
index d7de4b0653..3105eb8033 100755
--- a/contrib/subtree/git-subtree.sh
+++ b/contrib/subtree/git-subtree.sh
@@ -58,14 +58,14 @@ progress () {
assert () {
if ! "$@"
then
- die "assertion failed: " "$@"
+ die "assertion failed: $*"
fi
}
ensure_single_rev () {
if test $# -ne 1
then
- die "You must provide exactly one revision. Got: '$@'"
+ die "You must provide exactly one revision. Got: '$*'"
fi
}
@@ -690,7 +690,7 @@ cmd_add () {
cmd_add_repository "$@"
else
- say >&2 "error: parameters were '$@'"
+ say >&2 "error: parameters were '$*'"
die "Provide either a commit or a repository and commit."
fi
}
--
2.31.1
