Re: [PATCH v7 23/28] Reftable support for git-core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 21, 2021 at 12:44 AM Junio C Hamano <gitster@xxxxxxxxx> wrote:
> > +if test -n "$GIT_TEST_REFTABLE"
> > +then
> > +  test_set_prereq REFTABLE
> > +fi
>
> How would this interact with what the test prep series did which was
> to unconditionally add
>
> test_seq_prereq REFFILES
>
> around the same place?  Should $GIT_TEST_REFTABLE disable REFFILES?
> IOW, do you want the above to read
>
>         if test -n "$GIT_TEST_REFTABLE"
>         then
>                 test_set_prereq REFTABLE
>         else
>                 test_set_prereq REFFILES
>         fi
>
> when both series are in effect?

Yes, but on 2nd thought it's probably better to stick with just
REFFILES, and rewrite any reftable specific tests as !REFFILES.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux