On Mon, Apr 19 2021, Han-Wen Nienhuys via GitGitGadget wrote: > From: Han-Wen Nienhuys <hanwen@xxxxxxxxxx> > > Signed-off-by: Han-Wen Nienhuys <hanwen@xxxxxxxxxx> > --- > t/t5000-tar-tree.sh | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh > index 7204799a0b52..472fec4ee64a 100755 > --- a/t/t5000-tar-tree.sh > +++ b/t/t5000-tar-tree.sh > @@ -233,9 +233,10 @@ test_expect_success \ > test_cmp expected.mtime b.mtime' > > test_expect_success \ > - 'git get-tar-commit-id' \ > - 'git get-tar-commit-id <b.tar >b.commitid && > - test_cmp .git/$(git symbolic-ref HEAD) b.commitid' > + 'git get-tar-commit-id' \ > + 'git get-tar-commit-id <b.tar >actual && > + git rev-parse HEAD > expect && > + test_cmp expect actual' If we're doing a "re-style while we're at it" s/<spaces>/<tabs>/ let's just go all the way and convert it to a more modern style of: test_expect_success 'git get-tar-commit-id' ' ... ' But maybe such re-styling would be best left alone, and just a narrow change of the needed code. There's various surrounding tests in the file that use the same style, unless we're going to re-style all of them....
