Junio C Hamano <gitster@xxxxxxxxx> writes: > David Kastrup <dak@xxxxxxx> writes: > >>> Is that how other programs mentioned in the thread handle $EDITOR? >> >> If you are lucky. There is also the possibility that they just split >> on spaces without a way of quoting (see above), and in that case path >> names with spaces in them become completely impossible. >> >> I am not going to test all those applications _again_: the current >> code allows specifying commands with spaces in their names (by >> quoting) as well as commands with arguments, and both in an obvious >> manner. This is strictly better than being only able to do one or the >> other. >> >> I don't think you should revert the patch based on quite unspecific >> whining of someone who chose not to read the original discussion, but >> of course it is your call to make. > > Oh, I think you misunderstood me. I was saying > >> >> GIT_EDITOR="'/home/my programs/emacs' -nw" >> > > is a _good_ compromise. > > It just was that it would make it even _better_ compromise if we > can demonstrate that the above setting would work equally well > with other programs. No, it does not change the quality of a "compromise" if it can achieve strictly more than other programs. Anyway, try mkdir "c:\My Program" ln -s /usr/bin/yes "c:\My Program" EDITOR="\"c:\My Program/yes\" idiocy" VISUAL="$EDITOR" less /etc/motd v The output I get is idiocy +8 /etc/motd idiocy +8 /etc/motd idiocy +8 /etc/motd idiocy +8 /etc/motd [...] Puhleeze. I am certainly going to bring forward patches that are more complex in nature in future. I don't think it appropriate that I have to continuously defend myself against unspecific objections of somebody who chooses to not even read the discussion. If Dscho wants to voice an objection against a patch of mine, he can read up on the preceding discussion on news.gmane.org which is not affected by his killfile. Naturally, he will continue to mope about this and other patches of mine after the fact since he does not read articles like this. I can test all I like, and it won't and can't convince him since he does not get to see that. If he chooses to treat me like a pariah that is his choice and his own silliness. But if others join in his game, this won't help git development at all. So can we _please_ get this topic over with and stop ignoring the input I _already_ gave just because Dscho does? -- David Kastrup, Kriemhildstr. 15, 44793 Bochum - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
