merlyn@xxxxxxxxxxxxxx (Randal L. Schwartz) writes:
>>>>>> "Bill" == Bill Lear <rael@xxxxxxxxxx> writes:
>
> Bill> I was told eval was "wrong on multiple levels".
>
> I should elaborate.
>
> Using "eval" here means that you *then* have to be careful
> about whitespace quoting. For example, if my $HOME had a
> space in it, EDITOR="$HOME/bin/superemacs" would be broken if
> you add the extra eval, since the whitespace would be treated
> as a delimeter on the second lexing. I'd have to figure out
> how to set EDITOR with the right quotes or backwhacks in it to
> undo the effect of your eval.
All true.
Does the one in git-sh-setup.sh do that correctly? For
arguments I think it does the right thing (eval ... '"$@"' means
"give the four letter string " $ @ " to the shell, have it
expand and split the args --- which essentially means do not
molest them with $IFS). For the command name part, it does:
eval "${GIT_EDITOR:=vi}" '"$@"'
which means that you need to say
GIT_EDITOR="'/home/my programs/emacs' -nw"
if you installed your emacs in "/home/my programs/" directory
and want to pass a single leading parameter "-nw" to it.
Is that how other programs mentioned in the thread handle $EDITOR?
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
