Since [1] which has been out since v2.31.0 we've had a hard dependency on variadic macros. Removing the relevant always-off-unless-you-monkeypatch-the-source code may be too aggressive for Junio's "Let's give it enough time"[2]. But I'm submitting this because of brian m. carlson's note[3] about wanting to submit more general patches for declaring a hard dependency on all of C99. Whatever anyone thinks of that this harder dependency on C99 variadic macros would be a subset of such a change, so it makes sense to consider it first. Let's see if anyone has an issue with this landing before brian's suggested larger change. 1. https://lore.kernel.org/git/YBJLgY+CWtS9TeVb@xxxxxxxxxxxxxxxxxxxxxxx/ 2. https://lore.kernel.org/git/xmqq5z3hy4fq.fsf@xxxxxxxxxxxxxxxxxxxxxx/ 3. https://lore.kernel.org/git/YHOLo36MfuTj6YeD@xxxxxxxxxxxxxxxxxxxxxxxxx/ Ævar Arnfjörð Bjarmason (2): git-compat-util.h: clarify comment on GCC-specific code C99 support: remove non-HAVE_VARIADIC_MACROS code Documentation/CodingGuidelines | 3 ++ banned.h | 5 --- git-compat-util.h | 25 +++++------- trace.c | 73 ---------------------------------- trace.h | 62 ----------------------------- trace2.c | 39 ------------------ trace2.h | 25 ------------ usage.c | 10 ----- 8 files changed, 12 insertions(+), 230 deletions(-) -- 2.31.1.631.gb80e078001e
