Re: [PATCH] Document range looking syntax of git-diff arguments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes:

>>  Just in case if you are doing something exotic, it should be
>>  noted that all of the <commit> in the above description can be
>>  any <tree-ish>.
>
> If you document the ... thing, you should also fix the comment that comes 
> afterwards.
>
> The "commit...commit" syntax can *not* take a tree-ish, since it requires 
> the commit walker (for the common ancestor).

Thanks; I missed that when I committed a different version.

>> +Be careful that despite looking like so, both "<commit>..<commit>"
>> +and "<commit>...<commit>" forms are NOT ranges as described in
>> +the "SPECIFYING RANGES" section in gitlink:git-rev-parse[1].
>
> This might be worth specifying even more clearly somewhere, and explaining 
> *why*.
>
> "git diff" really is special, because it deals entirely in end-points. 
> Almost all of the rest of git is about *sets* of commits, rather than 
> just two end-points.

With respect to this point, I think what we already have as of
last night is much better than the above.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux