On Wed, 7 Apr 2021 at 01:16, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Ville Skyttä <ville.skytta@xxxxxx> writes: > > > If not set, referencing it in nounset (set -u) mode unguarded produces > > an error. > > > > Signed-off-by: Ville Skyttä <ville.skytta@xxxxxx> > > --- > > contrib/completion/git-completion.bash | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks. > > $ git grep -h -o -e '\$GIT_[A-Z_]*' master -- contrib/completion/git-completion.bash > > gives a few other hits. Thanks for checking. If we want to do what was proposed below: > I'd prefer to see that (1) the proposed > log message explain that the patch author audited all usages of > variables ...we need to go through not only ones starting with GIT_, but as is written above, _all_ variables, which is a larger task. To be clear, I haven't checked anything besides what was the subject of and change in the patch. I can go through all GIT_* while at it, but I'm not promising going through all variables at this point. Hopefully that's enough to get the resulting changes merged. Would be great if there were some automated tests to catch these issues, as they tend to crop up over time.
