On 01/04/21 18.40, Chinmoy Chakraborty wrote:
Greetings mentors, This is my draft proposal for the GSoC project, Convert submodule to builtin. It would be really helpful if you could review the draft and present your views on it :). Regards, Chinmoy Chakraborty. Link: https://github.com/chinmoy12c/GSoC/blob/master/GSoC_Git_proposal.pdf
Looking from your proposal, you seems like you're using Kali Linux as daily driver. Why do you do that? AFAIK Kali is for penetration testing purposes. I assumed that you know what you're doing if you use this distro as your general-purpose distro. And why not using Ubuntu/Mint/Debian/ Arch? Please see [1]. [1]: https://www.kali.org/docs/introduction/should-i-use-kali-linux/ But anyway, because we're at Git ML, let me review your proposal:
The following helper functions would be required to be implemented● A function to guess the directory name from the repository string. ● A function for normalizing path, that is, removing multiple //; leading ./; /./; /../; trailing / . ● A function to check for tracked directories properly as pointed out by Kaartic Sivaraam on the thread: https://lore.kernel.org/git/ce151a1408291bb0991ce89459e36ee1 3ccdfa52.camel@xxxxxxxxx/. ● A function to check if the path exists and is already a git repo, else clone it. ● A function to set the submodule config properly. After implementation of all these helper methods, the main `module_add()` function would be implemented using the helper functions listed above as well as those helper functions which are predefined.
I know these helper functions will be required for porting `git-submodule.sh` and used by `module_add()`, but do you have any justification for these? Anyway, I copy-pasted the quotation above from your proposal in PDF format. but when I pasted it into text-only mail, it looks rather ugly. So next time when sending GSoC proposal for Git, I would like to see proposals in Markdown format (as well as PDF) for the reason above. Thanks. -- An old man doll... just what I always wanted! - Clara
