Re: [RFC][PATCH] remarks about custom diff driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

> Also, you probably want to use the run-command.h "API" instead of rolling 
> it on your own, with strbuf.h to collect the converted text.  Otherwise 
> you would duplicate code, and make porting to Windows harder than 
> necessary.

Ahh. That is the thing I was looking for.

side-note: strbuf.h should also be used in populate_from_stdin (which
is currently O(n^2) because of a linear increment + xrealloc), and I
guess run-command.h can be used in spawn_prog regardless of my patch,
isn't it?

Thanks for your help,

-- 
Matthieu
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux