Hi, On Tue, 28 Aug 2007, Matthieu Moy wrote: > I started implementing something like this. The code is rather ugly (I'm > not so fluent in C, and not familiar with the git codebase ...), but it > gives an idea, and seems to work. Some comments: this patch would merit a cleanup patch first, which _only_ renames all the _diff_ stuff to _cmd_. That would make the actual patch very much easier to read, too. Also, you probably want to use the run-command.h "API" instead of rolling it on your own, with strbuf.h to collect the converted text. Otherwise you would duplicate code, and make porting to Windows harder than necessary. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
