On Fri, Mar 05, 2021 at 02:27:41PM -0500, Taylor Blau wrote: > instead of only when geometry->pack_nr == 0. But I was pretty sure that > the code below was doing the right thing even for geometry->pack_nr == > 1, and so I decided to avoid making this non-special case "special" by > returning early. After "I was pretty sure that the code was doing the right", I should note that I did the same thing you did in my head, and then confirmed my thinking by running the tests in t5326. Re-reading my response, I am worried that I gave the impression of being lackadaisical about testing.
