Hi Dyrone, Le 2021-02-25 à 04:13, Teng Long via GitGitGadget a écrit :
From: Teng Long <dyroneteng@xxxxxxxxx> Partial clones are created using 'git clone', but there is no related help information in the git-clone documentation. Add a relevant section to help users understand what partial clones are and how they differ from normal clones. The section briefly introduces the applicable scenarios and some precautions of partial clone. If users want to know more about its technical design and other details, users can view the link of git-partial-clone(7) according to the guidelines in the section. Signed-off-by: Teng Long <dyroneteng@xxxxxxxxx> --- clone: document partial clone sectionPartial clones are created using 'git clone', but there is no relatedhelp information in the git-clone documentation during a period. Add a relevant section to help users understand what partial clones are and how they differ from normal clones.The section briefly introduces the applicable scenarios and someprecautions of partial clone. If users want to know more about its technical design and other details, users can view the link of git-partial-clone(7) according to the guidelines in the section. Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-745%2Fdyrone%2Fmaster-v4 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-745/dyrone/master-v4 Pull-Request: https://github.com/git/git/pull/745 Range-diff vs v3: 1: 681c5dcb7904 ! 1: 6d543cc11378 clone: document partial clone section @@ ## Metadata ## -Author: Dyrone Teng <dyroneteng@xxxxxxxxx> +Author: Teng Long <dyroneteng@xxxxxxxxx>## Commit message ##clone: document partial clone sectionPartial clones are created using 'git clone', but there is no related- help information in the git-clone documentation during a period. Add - a relevant section to help users understand what partial clones are - and how they differ from normal clones. + help information in the git-clone documentation. Add a relevant section + to help users understand what partial clones are and how they differ + from normal clones.The section briefly introduces the applicable scenarios and someprecautions of partial clone. If users want to know more about its
The "range-diff" above is automatically inserted by GitGitGadget and shows what has changed since the last version you sent (i.e. it compares v3 to v4). So you adressed Junio's comment about your commit identity and signed-off-by identity needing to match, good. You also adressed my comment about the wording of the first paragraph of the commit message. But then I wrote: However, you did not address all the feedback I sent as a reply to patch 3/3 of v2 (see [1]). So it would be good to send a v5 with these suggestions incorporated (or, if you do not agree with a reviewer, you should still answer them and explain why). Cheers, Philippe. [1] https://lore.kernel.org/git/B90939A5-5693-4EB6-8F07-5B50F63B3143@xxxxxxxxx/
