Re: Help for the git patch with "---"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 2021-02-25 à 08:14, Philippe Blain a écrit :
Hi Dyrone,

[CC-ing the list]

Le 2021-02-25 à 04:36, 滕龙 a écrit :
--snip--
I decide to remove it from the PR.

So, did I deal the right way this time?

Well, if you are sending a subsequent version of your patch series,
this space is usually used to summarize in words what
has changed since the last version of the patch series.
For example, for your v4 you could have written:

Changes since v3:
- Improved <that> following comment from <insert reviewer name>
- Reworded the commit message
- etc.

This is a explained in the MyFirstContribution tutorial [1]. I would
encourage you to do that if your series needs a v5 (I haven't read it yet).
It's also a way to make sure that you modified your patch to account
for all feedback you got in earlier iterations.


Another thing: GitGitGadget adds a "CC:" footer in the PR description with
the email of every person that responds to your patch series on the mailing
list. This is then used to CC these persons when sending further iterations of
the series. So you should *not* remove these "CC:" footer when you update the PR
description to summarize you changes for each new version.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux