Shourya Shukla <periperidip@xxxxxxxxx> writes: >> Since we won't come to this block when doing index_only, we are >> allowed to touch the working tree contents and files. We indeed do >> "rm -rf" of the submodule working tree and touch .gitmodules file >> that is in the working tree. >> >> > } >> > + if (!remove_path_from_gitmodules(path)) >> > + gitmodules_modified = 1; >> > + continue; >> >> But this looks wrong. It might be OK to remove from the .gitmodules >> stored in the index, but I fail to see why it is justified to touch >> the working tree file when "--cached" is given. > > No no, you are correct. Phillipe pointed out the same thing. I don't > know how I made this mistake. > ... >> I think you'd need to >> ... > > Yeah, this approach seems perfect. I will do it this way. OK, then let's go that way. Thanks.
