On Wed, Feb 17, 2021 at 8:22 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > On Wed, Feb 17, 2021 at 6:04 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Matheus Tavares <matheus.bernardino@xxxxxx> writes: > > > +for opt in "" -f -u --ignore-removal > > > +do > > > + if test -n "$opt" > > > + then > > > + opt=" $opt" > > > + fi > > > + test_expect_success "git add$opt does not update SKIP_WORKTREE entries" ' > > > ... A more idiomatic way to do this would > have been: > > for opt in "" -f -u --ignore-removal > do > test_expect_success " git add${opt:+ $opt} does ..." ' That's much better, thanks :)