Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes:
> On Wed, Feb 17, 2021 at 6:04 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> Matheus Tavares <matheus.bernardino@xxxxxx> writes:
>> > +for opt in "" -f -u --ignore-removal
>> > +do
>> > + if test -n "$opt"
>> > + then
>> > + opt=" $opt"
>> > + fi
>> > + test_expect_success "git add$opt does not update SKIP_WORKTREE entries" '
>>
>> The above is cumulative, and as a consequence, "git add -u <path>"
>> is not tested, but "git add -f -u <path>" is. Intended? How was
>> the order of the options listed in "for opt in ..." chosen?
>
> I may be misreading, but I don't think this is cumulative (though it's
> easy to mistake it as such due to the way it inserts a space before
> $opt).
Ah, yes, I misread it.
> ... A more idiomatic way to do this would
> have been:
>
> for opt in "" -f -u --ignore-removal
> do
> test_expect_success " git add${opt:+ $opt} does ..." '
Yes, indeed.
