On Wed, Feb 3, 2021 at 10:46 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Derrick Stolee <stolee@xxxxxxxxx> writes: > > >> /* All done? */ > >> - if (!num_destinations) > >> + if (!num_destinations || !num_sources) > >> goto cleanup; > > > > And add an extra quit condition which is very possible to hit. > > Is it only hit when every "delete" is actually a rename? > > When every delete is actually an unmodified exact rename, I think. Yes, exactly. > If this simple change gives us good performance gain, that is > superb. > > Nicely done. Thanks. I probably should have separated this from the speculative not-quite-working changes that weren't ready yet and pushed just it sooner.[1] But I kinda wanted to get all the performance changes together, and...well, all the other performance changes took a while to complete (especially given multiple starts and stops). [1] https://lore.kernel.org/git/20171110222156.23221-2-newren@xxxxxxxxx/
