Derrick Stolee <stolee@xxxxxxxxx> writes: >> /* All done? */ >> - if (!num_destinations) >> + if (!num_destinations || !num_sources) >> goto cleanup; > > And add an extra quit condition which is very possible to hit. > Is it only hit when every "delete" is actually a rename? When every delete is actually an unmodified exact rename, I think. If this simple change gives us good performance gain, that is superb. Nicely done.
