On Mon, Feb 1, 2021 at 6:41 PM Derrick Stolee <stolee@xxxxxxxxx> wrote: > > On 2/1/2021 6:54 PM, Elijah Newren wrote: > > On Mon, Jan 25, 2021 at 9:42 AM Derrick Stolee via GitGitGadget > > <gitgitgadget@xxxxxxxxx> wrote: > >> In this test, I also used "echo >>README.md" to append a line to the > >> README.md file, so the 'git add .' command is doing _something_ other > >> than a no-op. Without this edit (and FS Monitor enabled) the small > >> tree case again gains about 30ms on the sparse index case. > > > > Meaning the small tree is 30 ms faster than reported here, or 30 ms > > slower, or that both sparse index and small tree are faster but the > > small tree decreases its time more than the sparse index one does? > > > > Sorry, I don't mean to be dense, I'm just struggling with > > understanding words today it seems. (Also, it seems like there's a > > joke in there about me being "dense" in a review of a "sparse" > > feature...but I'm not quite coming up with it.) > > I don't blame you! This is a lot to digest, and I appreciate you > pushing through to the end of it. > > Clearly, I was getting a bit inexact near the end. My excitement > to share this RFC clearly overshadowed my attention to grammatical > detail. I'll go through your feedback more carefully soon and > hopefully clarify these and many other questions. I can't blame you for being excited; this series is awesome. I've thought we should do something along this direction for years[1]. Sure I found lots of little nitpicks here and there in your series, but that's just attempting to help find any issues so it can be made even better; overall I'm super excited about it. [1] See "crazy idea" paragraph at https://lore.kernel.org/git/CABPp-BGir_5xyqEfwytDog0rZDydPHXjuqXCpNKk67dVPXjUjA@xxxxxxxxxxxxxx/
