On Fri, Jan 22, 2021 at 9:32 PM Jeff King <peff@xxxxxxxx> wrote: > I also found the use of " exec" clever, > but rather subtle; you need the extra space so that our "don't bother > using a shell" run-command optimization does not kick in. I replaced it > with "env" here, which is a slightly more canonical way of running a > sub-program that does not rely on shell builtins. Yes good idea, the exec thing is too clever for its own good. > But all of this should be added as a new test, probably in t5544 with > the other pack-objects hook tests. Did that, hope it is what you had in mind. > I'm somewhat embarrassed to say that despite being the one who added the > pack-objects hook 4 years ago, we still have not switched over to it at > GitHub from our custom patch (the reason is just mundane; there's some > other adjustments that would have to happen and nobody has ever quite > gotten around to it). Presumably you are looking to use it at GitLab. > Just beware that you are probably treading new-ish ground, so there may > be other bugs like this lurking. Thanks for the heads up! Jacob
