I also spent time being confused about what is going on, and wondering if that other ref iteration ever worked. I went as far as inspecting git-verify-pack -v output to look at object order. :) On the other hand, through working on this I learned that include-tag has pretty effective test coverage so if peel_ref didn't work or stopped working, we'd find out. If there is a better way to write "for each tag + peel ref" I am happy to change the patch, just let me know what it should look like. Best regards, Jacob Vosmaer GitLab, Inc. On Wed, Jan 20, 2021 at 5:19 PM Taylor Blau <me@xxxxxxxxxxxx> wrote: > > On Wed, Jan 20, 2021 at 11:18:11AM -0500, Jeff King wrote: > > So I think both the existing and the new calls using for_each_tag_ref() > > are OK here. > > Indeed, I followed the same trail of calls as you did and reached the > same conclusion, but didn't write any of it down here since I thought it > wasn't worthwhile. > > But, yes, I agree that both are safe. > > Thanks, > Taylor
