Re: [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs
From: Taylor Blau <me@xxxxxxxxxxxx>
Date: Wed, 20 Jan 2021 11:19:41 -0500
Cc: Taylor Blau <me@xxxxxxxxxxxx>, Jacob Vosmaer <jacob@xxxxxxxxxx>, git@xxxxxxxxxxxxxxx, avarab@xxxxxxxxx
In-reply-to: <YAhXw9Gvn5Pyvacq@coredump.intra.peff.net>
References: <20210120124514.49737-1-jacob@gitlab.com> <20210120124514.49737-2-jacob@gitlab.com> <YAhC8Gsp4H17e28n@nand.local> <YAhXw9Gvn5Pyvacq@coredump.intra.peff.net>

On Wed, Jan 20, 2021 at 11:18:11AM -0500, Jeff King wrote:
> So I think both the existing and the new calls using for_each_tag_ref()
> are OK here.

Indeed, I followed the same trail of calls as you did and reached the
same conclusion, but didn't write any of it down here since I thought it
wasn't worthwhile.

But, yes, I agree that both are safe.

Thanks,
Taylor

Follow-Ups:
- Re: [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs
  - From: Jeff King
- Re: [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs
  - From: Jacob Vosmaer

References:
- [PATCH v2 0/1] builtin/pack-objects.c: avoid iterating all refs
  - From: Jacob Vosmaer
- [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs
  - From: Jacob Vosmaer
- Re: [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs
  - From: Taylor Blau
- Re: [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs
  - From: Jeff King

Prev by Date: Re: [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs
Next by Date: Re: [PATCH 1/1] builtin/pack-objects.c: avoid iterating all refs
Previous by thread: Re: [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs
Next by thread: Re: [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]