On Fri, Jan 15, 2021 at 04:32:34AM -0500, Jeff King wrote: > On Thu, Jan 14, 2021 at 12:53:19PM -0800, Junio C Hamano wrote: > > > Jeff King <peff@xxxxxxxx> writes: > > > > > On Wed, Jan 13, 2021 at 05:23:25PM -0500, Taylor Blau wrote: > > > > > >> In this revision, I addressed feedback from Junio, Peff, and Stolee. A > > >> range-diff is included below, but the main changes are: > > >> > > >> - Error messages are improved to include the pack and offset when applicable. > > >> - Variable names were made clearer (e.g., n -> index_pos). > > >> - Comments were added in pack-revindex.h to introduce relevant terminology, > > >> and which methods convert between what orderings. > > >> - int-sized lower- and upper-bounds were converted to be unsigned. > > > > > > Thanks, this addresses all of my nits. I responded to a few of Junio's > > > reviews with some further comments/suggestions; the most interesting one > > > is using "index_pos" to indicate the ordering more clearly in patch 15. > > > I'm happy with or without including that. > > > > I think it is better to leave it for future "clean-up" outside the > > series, to be done after the series hits a released version. > > OK. I'll hold on to it and re-send it after the area has settled. Oh, nevermind, you said elsewhere you'd pick it up as 21/20. Assuming you do that, I won't resend it. :) -Peff
