On Wed, Jan 13, 2021 at 05:23:25PM -0500, Taylor Blau wrote: > In this revision, I addressed feedback from Junio, Peff, and Stolee. A > range-diff is included below, but the main changes are: > > - Error messages are improved to include the pack and offset when applicable. > - Variable names were made clearer (e.g., n -> index_pos). > - Comments were added in pack-revindex.h to introduce relevant terminology, > and which methods convert between what orderings. > - int-sized lower- and upper-bounds were converted to be unsigned. Thanks, this addresses all of my nits. I responded to a few of Junio's reviews with some further comments/suggestions; the most interesting one is using "index_pos" to indicate the ordering more clearly in patch 15. I'm happy with or without including that. -Peff
