On Tue, Jan 12, 2021 at 09:21:59AM +0100, Christian Couder wrote: > Let's replace the 2 different pieces of code that write a > promisor file in 'builtin/repack.c' and 'fetch-pack.c' > with a new function called 'write_promisor_file()' in > 'pack-write.c' and 'pack.h'. This is just great. Even though I'm sure that I have read that code in builtin/repack.c a hundred times before, I for some reason always have to remind myself what it is doing. So, I'm very happy to see that it is being cleaned up behind a function whose name describes its behavior clearly. And, if that function can be used to remove some duplication in a sensible fashion along the way, then all the better. Reviewed-by: Taylor Blau <me@xxxxxxxxxxxx> Thanks, Taylor
