Re: [PATCH 0/5] avoid peeking into `struct lock_file`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 7 Jan 2021 at 09:19, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> Martin Ågren <martin.agren@xxxxxxxxx> writes:
>
> > I could add a remark in the commit message of the last patch along the
> > lines of "After this commit, renaming the `tempfile` field only triggers
> > compilation errors in lockfile.[ch] and this one instance that we're
> > intentionally leaving here.".
>
> It would be a nice addition to the log message to help readers to
> feel confident about the conversion.  It is OK if you want to add
> one, and certainly a good trick to have in your toolbox for your
> next conversion, but it may not be worth rerolling only to update
> the log message with such a remark.

Ok, got it. So I'm not planning to reroll this series. Unless something
else shows up, obviously.

Thank you.

Martin




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux