I made a comment in [1] about how we could avoid peeking into a `struct lock_file` and instead use a helper function that we happen to have at our disposal. I then grepped around a bit and found that we're pretty good at avoiding such peeking at the moment, but that we could do a bit better. Here's a series to avoid such `lk.tempfile.foo` in favor of `get_lock_file_foo(&lk)`. [1] https://lore.kernel.org/git/CAN0heSrOKr--GenbowHP+iwkijbg5pCeJLq+wz6NXCXTsfcvGg@xxxxxxxxxxxxxx/ Martin Ågren (5): builtin/gc: don't peek into `struct lock_file` commit-graph: don't peek into `struct lock_file` midx: don't peek into `struct lock_file` refs/files-backend: don't peek into `struct lock_file` read-cache: try not to peek into `struct {lock_,temp}file` builtin/gc.c | 6 +++--- commit-graph.c | 6 +++--- midx.c | 2 +- read-cache.c | 12 ++++++------ refs/files-backend.c | 4 ++-- 5 files changed, 15 insertions(+), 15 deletions(-) -- 2.30.0
