On 12/9/2020 2:16 PM, Josh Steadmon wrote: > Whoops, had a small think-o while writing the patch message. Fixed > below. > > -- >8 -- > Subject: [PATCH] t7900: use --fixed-value in git-maintenance tests > > Use --fixed-value in git-config calls in the git-maintenance tests, so > that the tests will continue to work even if the repo path contains > regexp metacharacters. > > Signed-off-by: Josh Steadmon <steadmon@xxxxxxxxxx> > --- > t/t7900-maintenance.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh > index fab0e01c39..41bf523953 100755 > --- a/t/t7900-maintenance.sh > +++ b/t/t7900-maintenance.sh > @@ -422,7 +422,7 @@ test_expect_success 'start from empty cron table' ' > GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance start && > > # start registers the repo > - git config --get --global maintenance.repo "$(pwd)" && > + git config --get --global --fixed-value maintenance.repo "$(pwd)" && > > grep "for-each-repo --config=maintenance.repo maintenance run --schedule=daily" cron.txt && > grep "for-each-repo --config=maintenance.repo maintenance run --schedule=hourly" cron.txt && > @@ -433,7 +433,7 @@ test_expect_success 'stop from existing schedule' ' > GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance stop && > > # stop does not unregister the repo > - git config --get --global maintenance.repo "$(pwd)" && > + git config --get --global --fixed-value maintenance.repo "$(pwd)" && > > # Operation is idempotent > GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance stop && Thank you for this. While I went to make sure the maintenance builtin worked properly, I forgot to check the rest of the test script worked as well. This is a good way to fix that. Thanks, -Stolee
