On 2020.10.15 17:22, Derrick Stolee via GitGitGadget wrote: > diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh > index 8f383d01d9..7715e40391 100755 > --- a/t/t7900-maintenance.sh > +++ b/t/t7900-maintenance.sh > @@ -315,4 +315,32 @@ test_expect_success 'register and unregister' ' > test_cmp before actual > ' > > +test_expect_success 'start from empty cron table' ' > + GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance start && > + > + # start registers the repo > + git config --get --global maintenance.repo "$(pwd)" && > + > + grep "for-each-repo --config=maintenance.repo maintenance run --schedule=daily" cron.txt && > + grep "for-each-repo --config=maintenance.repo maintenance run --schedule=hourly" cron.txt && > + grep "for-each-repo --config=maintenance.repo maintenance run --schedule=weekly" cron.txt > +' > + > +test_expect_success 'stop from existing schedule' ' > + GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance stop && > + > + # stop does not unregister the repo > + git config --get --global maintenance.repo "$(pwd)" && > + > + # Operation is idempotent > + GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance stop && > + test_must_be_empty cron.txt > +' > + > +test_expect_success 'start preserves existing schedule' ' > + echo "Important information!" >cron.txt && > + GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance start && > + grep "Important information!" cron.txt > +' > + > test_done These two test cases fail when the paths passed to git-config contain ERE metacharacters [similar to the issue addressed in 483a6d9b5da (maintenance: use 'git config --fixed-value', 2020-11-25)]. Since these are already in next, I'm providing a patch to add '--fixed-value' to the git-config calls here as well. -- >8 -- Subject: [PATCH] t7900: use --fixed-value in git-maintenance tests Use --fixed-value in git-config calls in the git-maintenance tests, so that the tests will continue to work even if the repo path contains shell metacharacters. Signed-off-by: Josh Steadmon <steadmon@xxxxxxxxxx> --- t/t7900-maintenance.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh index fab0e01c39..41bf523953 100755 --- a/t/t7900-maintenance.sh +++ b/t/t7900-maintenance.sh @@ -422,7 +422,7 @@ test_expect_success 'start from empty cron table' ' GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance start && # start registers the repo - git config --get --global maintenance.repo "$(pwd)" && + git config --get --global --fixed-value maintenance.repo "$(pwd)" && grep "for-each-repo --config=maintenance.repo maintenance run --schedule=daily" cron.txt && grep "for-each-repo --config=maintenance.repo maintenance run --schedule=hourly" cron.txt && @@ -433,7 +433,7 @@ test_expect_success 'stop from existing schedule' ' GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance stop && # stop does not unregister the repo - git config --get --global maintenance.repo "$(pwd)" && + git config --get --global --fixed-value maintenance.repo "$(pwd)" && # Operation is idempotent GIT_TEST_CRONTAB="test-tool crontab cron.txt" git maintenance stop && -- 2.29.2.576.ga3fc446d84-goog
