On Fri, Oct 9, 2020 at 11:13 PM Emily Shaffer <emilyshaffer@xxxxxxxxxx> wrote: > > On Thu, Oct 01, 2020 at 08:58:51PM -0700, Jonathan Nieder wrote: > > > > Hi, > > > > Han-Wen Nienhuys wrote: > > > > > reftable/reftable.h | 585 ++++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 585 insertions(+) > > > create mode 100644 reftable/reftable.h > > > > Adding a header in a separate patch from the implementation doesn't > > match the usual practice. Can we add declarations in the same patch > > as the functions being declared instead? > > > > We could still introduce the header early in its own patch if we want, > > but it would be a skeleton of a header that gets filled out by later > > patches. > > To poke a little deeper into what I think Jonathan is trying to say: > > Of course, taking a completed project - like your initial reftable > submission - and then chopping it up into a cute story of commits is a > pain in the ***. Doing it twice - or more - is just aggravating. So I > wonder whether we can bikeshed what story would look nice before you > even pick up your 'git rebase -i'? Doing that bikeshedding here on list Looks like this didn't happen. I went with Jonathan's suggestion, and chopped the public API header in smaller bits. PTAL. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
