Re: [PATCH v2 09/11] add -i (Perl version): include indentation in the colored header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Phillip,

On Fri, 13 Nov 2020, Phillip Wood wrote:

> On 11/11/2020 12:28, Johannes Schindelin via GitGitGadget wrote:
> > From: Johannes Schindelin <johannes.schindelin@xxxxxx>
> >
> > The header is formatted by padding each column heading with spaces up to
> > the length of 12 characters. These padding spaces are naturally included
> > when coloring the entire header.
> >
> > However, the preceding five spaces indentation for non-flat lists were
> > _not_ included in the Perl version, but _were_ included in the built-in
> > version. Let's adjust the former to align with the latter's behavior.
>
> I had trouble understanding this. I think my confusion is that the padding was
> printed when the header was colored, but it was not inside the colored part
> whereas the subject lead be to think there was no indentation printed when the
> header was colored.

Right, this is ambiguous, but I thought it was clear from the first
paragraph that "included" means "when coloring".

I'm not a native speaker, though, so I welcome suggestions to improve
this.

> I assume this change is so that we can use the same test for both
> versions?

Correct.

Thanks,
Dscho




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux