Hi Phillip, On Fri, 13 Nov 2020, Phillip Wood wrote: > On 11/11/2020 12:28, Johannes Schindelin via GitGitGadget wrote: > > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > > The Perl version of this command colors the progress indicator and the > > prompt message in one go, let's do the same in the built-in version. > > Why? the C version has access to an api that means we don't have to remember > to print the reset string each time so why move away from that? I don't think > it matters to the user that there are some extra escape codes in the prompt of > the C version. The answer is probably "so we can use the same test as the perl > version" which might be a good reason - if it is I think it would be helpful > to say so in the commit message. Honestly, the number one reason is so that the _same_ test passes using the Perl version as well as with the built-in version, something that is required by the `linux-clang` job in our CI build. I am not really willing to change this, unless I hear a goooood reason to complicate the test. Ciao, Dscho
