On Wed, Nov 11, 2020 at 8:51 AM Derrick Stolee <stolee@xxxxxxxxx> wrote: > > On 11/11/2020 11:47 AM, Elijah Newren wrote: > > On Wed, Nov 11, 2020 at 5:54 AM Derrick Stolee <stolee@xxxxxxxxx> wrote: > >> > >> On 11/2/2020 3:43 PM, Elijah Newren wrote: > >>> I have some ideas for using a histogram diff to improve content merges, > >>> which fundamentally relies on the idea of a histogram. Since the diffs > >>> are never displayed to the user but just used internally for merging, > >>> the typical user preference shouldn't matter anyway, and I want to make > >>> sure that all my testing works with this algorithm. > >>> > >>> Granted, I don't yet know if those ideas will pan out and I haven't even > >>> tried any of them out yet, but it's easy to change the diff algorithm in > >>> the future if needed or wanted. For now, just set it to histogram. > >> > >> If you are not making use of the histogram yet, then could you set this > >> patch aside until you _do_ use it? Or are there performance implications > >> that are also a side benefit? > > > > Long story... > > ... > > > Does that help? > > In summary, you have some concrete reasons to prefer the histogram > diff other than just "I have some ideas that might pan out later" so > this code change is a good one but could be better justified in the > commit message. Does that sound correct? Sure, I can add some additional wording about those ideas and the concrete issues I want to fix.
