On Mon, Nov 09, 2020 at 11:12:14PM +0100, Anders Waldenborg wrote: > > Why is this new test important? > > The test that checks that 'git log --pretty=format:%(trailers)' shows > the output in the form "Closes: 1234" even if input was "Closes #1234" > is interesting both because it checks that this behavior is kept intact > in the patches later in the series which modifies handling of separator > and because it is a behavior that can be surprising and not well defined > in documentation and those tend to be the ones that are easiest to > accidentally break. Maybe the addition of the test should come later in > the series where the changes that potentially could break it happen. That makes sense, but should be in the commit message. I also found the expected output confusing. I thought at first we were mis-parsing to include part of the subject in the trailer, but it is just that we put "%s" into the format argument. > It seems like you stopped reviewing my patch series at patch 06/21. That > is IMHO just before it starts to get interesting :) Now I don't know if > rest of it was rubbish or uninteresting or just there was no time to > look at it. > > I've updated according to the suggestions, but not sure if I should > repost the series with just such small adjustments. Reviewing this has been on my todo list, but I'd just as soon do it from your latest version. Since it has been a while, it may make sense to just repost with the fixes, and note in the cover letter that it didn't get a lot of review yet. -Peff
