On 11/3/2020 5:27 PM, Eric Sunshine wrote: > On Tue, Nov 3, 2020 at 4:22 PM Derrick Stolee <stolee@xxxxxxxxx> wrote: >> On 11/3/2020 1:45 PM, Eric Sunshine wrote: >>> It's not clear whether or not this is saying that git-maintenance will >>> dynamically adapt to work with modern and older 'launchctl'. A glance >>> at the actual code reveals that it knows only about modern >>> 'bootstrap'. Perhaps this could be a bit clearer by saying that it >>> only supports modern versions, and that support for older versions can >>> be added later if needed. (For those of us who are stuck with 10-20 >>> year old hardware and OS versions, 2015 isn't that long ago.) >> >> Yes, this is a strange place to be. How far do we go back to support >> as many users as possible? How many users will be simultaneously >> stuck on an old version of macOS _and_ interested in updating to this >> latest version of Git? Is that worth the extra functionality to detect >> the the OS version and change commands? > > I don't think this patch series needs to answer these questions > provided that it doesn't close the door to someone adding > older-version support down the road. My review comment was more about > the commit message being clearer about the choice -- supporting only > recent 'launchctl' -- being made by this series. (And perhaps the > documentation could mention that it requires a reasonably modern > 'launchctl'.) Thanks. I'll be sure to make the commit message more clear. >> This makes me realize that I should update the documentation to give >> pointers for how to view the schedules for each platform: >> >> - Windows: Open "Task Scheduler" >> - macOS: 'launchctl list | grep org.git-scm.git' >> - Others: 'crontab -l' > > Good idea. > > I haven't looked at the documentation, but if it doesn't already, I > wonder if it should give examples of how to set these up by hand or > how to customize the ones created by git-maintenance itself. I was > also wondering if git-maintenance could have a mode in which it > generates the template file(s) for you but doesn't actually > activate/install it, instead providing instructions for > activation/installation. That way, people could modify the scheduling > file before actually activating it. However, this may all be outside > the scope of the patch series, and could be done later if desired. Outside of the technical details, the biggest questions I've tried to handle with the background maintenance feature has been to balance customization with ease-of-use. My philosophy is that users fall into a few expertise buckets, and have different expectations: * Beginners will never know about background maintenance and so will never run "git maintenance start" or set the config values. * Intermediate users might discover "git maintenance start" and will appreciate that they don't need to learn cron to set up a good default schedule. * Advanced users will read the documentation and use Git config settings to customize their maintenance tasks and schedule. * Expert users might decide the task schedule available by "git maintenance start" is too restrictive, so they create their own background schedule with custom tasks. They might not even run the maintenance builtin and opt instead for 'git gc' or 'git repack' directly! My main target has been these "intermediate" users who might run the command and forget about it. However, I've also tried to keep the advanced users in mind with the advanced config options available. Your comment about documentation demonstrates a way to serve the advanced and expert users by providing a clear framework for discovering what Git is doing under the hood and how to modify or adapt that to their needs. It is also important to demonstrate how to set up schedules in a similar way without having them be overwritten by a later "git maintenance start" command. I will give this a shot in v2. Thanks. -Stolee
