On Tue, Nov 3, 2020 at 4:22 PM Derrick Stolee <stolee@xxxxxxxxx> wrote: > On 11/3/2020 1:45 PM, Eric Sunshine wrote: > > It's not clear whether or not this is saying that git-maintenance will > > dynamically adapt to work with modern and older 'launchctl'. A glance > > at the actual code reveals that it knows only about modern > > 'bootstrap'. Perhaps this could be a bit clearer by saying that it > > only supports modern versions, and that support for older versions can > > be added later if needed. (For those of us who are stuck with 10-20 > > year old hardware and OS versions, 2015 isn't that long ago.) > > Yes, this is a strange place to be. How far do we go back to support > as many users as possible? How many users will be simultaneously > stuck on an old version of macOS _and_ interested in updating to this > latest version of Git? Is that worth the extra functionality to detect > the the OS version and change commands? I don't think this patch series needs to answer these questions provided that it doesn't close the door to someone adding older-version support down the road. My review comment was more about the commit message being clearer about the choice -- supporting only recent 'launchctl' -- being made by this series. (And perhaps the documentation could mention that it requires a reasonably modern 'launchctl'.) > This makes me realize that I should update the documentation to give > pointers for how to view the schedules for each platform: > > - Windows: Open "Task Scheduler" > - macOS: 'launchctl list | grep org.git-scm.git' > - Others: 'crontab -l' Good idea. I haven't looked at the documentation, but if it doesn't already, I wonder if it should give examples of how to set these up by hand or how to customize the ones created by git-maintenance itself. I was also wondering if git-maintenance could have a mode in which it generates the template file(s) for you but doesn't actually activate/install it, instead providing instructions for activation/installation. That way, people could modify the scheduling file before actually activating it. However, this may all be outside the scope of the patch series, and could be done later if desired.
