); SAEximRunCond expanded to false This testcases shows why prefix matching shouldn't be used when using configured trailers to classify lines as trailers or not. Signed-off-by: Anders Waldenborg <anders@xxxxxxx> --- t/t7513-interpret-trailers.sh | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/t/t7513-interpret-trailers.sh b/t/t7513-interpret-trailers.sh index 4b3a2484b5..b1e9a9e6d1 100755 --- a/t/t7513-interpret-trailers.sh +++ b/t/t7513-interpret-trailers.sh @@ -239,6 +239,35 @@ test_expect_success 'with non-trailer lines mixed with a configured trailer' ' test_cmp expected actual ' +# This fails because "c:/windows/tmp/stuff/temp.txt" is classified as +# a trailer line because "c" is a prefix of "Confirmed-By". Therefore +# the new trailer is appended to that (non-trailer) block rather than +# creating a new block. It also canonicalize the "trailer" to +# "Confirmed-By: /windows/tmp/stuff/temp.txt" +test_expect_failure 'with non-trailer lines mixed with prefix of configured trailer' ' + cat >patch <<-\EOF && + some subject + + This is clearly not a trailer line. But + on next line there is a a windows path + c:/windows/tmp/stuff/temp.txt but that + should not make this classify as a trailer block + EOF + cat >expected <<-\EOF && + some subject + + This is clearly not a trailer line. But + on next line there is a a windows path + c:/windows/tmp/stuff/temp.txt but that + should not make this classify as a trailer block + + t: v + EOF + test_config trailer.confirmedby.key "Confirmed-By" && + git interpret-trailers --trailer "t: v" patch >actual && + test_cmp expected actual +' + test_expect_success 'with non-trailer lines mixed with a non-configured trailer' ' cat >patch <<-\EOF && -- 2.25.1
